avoid using pyaudio if not needed #83
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'll let @chadbailey59 take a look at this one, since he's going to move the VAD stuff into a FrameProcessor so it can co-exist with other audio stuff like the Whisper FrameProcessor. |
chadbailey59
approved these changes
Mar 28, 2024
chadbailey59
force-pushed
the
pyaudio-not-needed
branch
from
89f0681 to
61b961f
Compare
|
Ah, Moishe ended up adding a local transport that uses pyaudio pretty extensively, so I'm going to close this PR in favor of another PR I'm working on to modularize some dependencies. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initializing pyaudio and not deinitializing properly might cause system audio issues (experienced it in daily-python). So, since we are not using it for anything in the base transport, we should just remove it.